Re: [PATCH v2 04/12] qemu: domain: Assume 'raw' default storage format also for network storage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/5/18 8:14 AM, Peter Krempa wrote:
> Post parse callback adds the 'raw' type only for local files. Remote
> files can also have backing store (even local) so we should do this also
> for network backed storage.

NIT: The .xml/.args in this patch are not all remote storage - they are
volume storage...

The disk-source-pool-mode.args gets the look/feel of remote from
virDomainDiskTranslateISCSIDirect

John

> 
> Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
> ---
>  src/qemu/qemu_domain.c                             | 4 +---
>  tests/qemuxml2argvdata/disk-source-pool-mode.args  | 6 +++---
>  tests/qemuxml2argvdata/disk-source-pool.args       | 4 ++--
>  tests/qemuxml2xmloutdata/disk-source-pool-mode.xml | 6 +++---
>  tests/qemuxml2xmloutdata/disk-source-pool.xml      | 2 +-
>  5 files changed, 10 insertions(+), 12 deletions(-)
> 

[...]

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux