On Fri, Oct 05, 2018 at 04:11:45PM +0800, Shi Lei wrote: > This patch replaces those 'my varname;' with 'our varname;', i.e. > it uses global var, rather than passing arguments to subroutine. > So it can be a bit faster. NACK Use of global variables like this is harmful to maintenance of the code. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
