On Wed, Oct 07, 2009 at 03:34:38PM -0400, Amy Griffis wrote: > Daniel P. Berrange wrote: [Tue Oct 06 2009, 05:00:55AM EDT] > > > > Having looked at the wway the next patch uses these, I think it'd be > > > > nicer to change the contract to just be > > > > > > > > extern char *virLogGetFilters(void); > > > > extern char *virLogGetOutputs(void); > > > > > > Heh, that's how I wrote it the first time. Then I changed it to > > > make use of the virBuffer API, and tried to follow precedent with > > > the rest of libvirt. The code is not really doing much with the > > > string, maybe virBuffer is overkill? > > > > The general rule to try & follow is that if you just have a single > > printf style call to make, then use virAsprintf. If you have several > > printf/strcat calls to make, then use virBuffer. > > > > In this particular case, its fine to use virBuffer for your internal > > impl - I just thing its better to not include it in the public API, > > convert the virBuffer into a char * for the return value > > That makes sense. Does this look good now? Yup, looks fine to me too, the accessors will be more generally useful, good idea ! Applied, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@xxxxxxxxxxxx | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/ -- Libvir-list mailing list Libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list