Add test coverage for all the possible devices and move all the socket creation to qemuProcessPrepareHost. TBD: remove the racy qemuSecuritySetSocketLabel call as well as the rest of host state modification out of qemuBuildCommandLine Ján Tomko (15): tests: add smartcard-passthrough-unix tests: add parallel-unix-chardev tests: add channel-unix-guestfwd tests: add console-virtio-unix tests: add usb-redir-unix tests: add virtio-rng-egd-unix tests: use real capabilities for net-vhostuser qemuProcessPrepareDomain: pass xmlopt when creating monConfig qemu: add fd to qemuDomainChrSourcePrivate qemuBuildChrChardevStr: split attribute formatting qemuBuildChrChardevStr: increase scope of qemuBuildChrChardevStr qemuBuildChrChardevStr: pass fd from private data qemu: remove QEMU_BUILD_CHARDEV_UNIX_FD_PASS qemuBuildCommandLine: do not pass security manager qemuOpenChrChardevUNIXSocket: move to qemu_process src/qemu/qemu_command.c | 192 +++++---------------- src/qemu/qemu_command.h | 5 - src/qemu/qemu_domain.c | 3 + src/qemu/qemu_domain.h | 2 + src/qemu/qemu_process.c | 188 +++++++++++++++++++- src/qemu/qemu_process.h | 3 + .../channel-unix-guestfwd.x86_64-2.5.0.args | 33 ++++ .../channel-unix-guestfwd.x86_64-latest.args | 36 ++++ tests/qemuxml2argvdata/channel-unix-guestfwd.xml | 37 ++++ .../console-virtio-unix.x86_64-2.5.0.args | 34 ++++ .../console-virtio-unix.x86_64-latest.args | 37 ++++ tests/qemuxml2argvdata/console-virtio-unix.xml | 33 ++++ .../net-vhostuser.x86_64-2.5.0.args | 39 +++++ .../net-vhostuser.x86_64-latest.args | 42 +++++ .../parallel-unix-chardev.x86_64-2.5.0.args | 33 ++++ .../parallel-unix-chardev.x86_64-latest.args | 36 ++++ tests/qemuxml2argvdata/parallel-unix-chardev.xml | 35 ++++ .../smartcard-passthrough-unix.x86_64-2.5.0.args | 30 ++++ .../smartcard-passthrough-unix.x86_64-latest.args | 33 ++++ .../smartcard-passthrough-unix.xml | 19 ++ .../usb-redir-unix.x86_64-2.5.0.args | 35 ++++ .../usb-redir-unix.x86_64-latest.args | 38 ++++ tests/qemuxml2argvdata/usb-redir-unix.xml | 45 +++++ .../virtio-rng-egd-unix.x86_64-2.5.0.args | 30 ++++ .../virtio-rng-egd-unix.x86_64-latest.args | 33 ++++ tests/qemuxml2argvdata/virtio-rng-egd-unix.xml | 29 ++++ tests/qemuxml2argvmock.c | 3 +- tests/qemuxml2argvtest.c | 14 ++ 28 files changed, 939 insertions(+), 158 deletions(-) create mode 100644 tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-2.5.0.args create mode 100644 tests/qemuxml2argvdata/channel-unix-guestfwd.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/channel-unix-guestfwd.xml create mode 100644 tests/qemuxml2argvdata/console-virtio-unix.x86_64-2.5.0.args create mode 100644 tests/qemuxml2argvdata/console-virtio-unix.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/console-virtio-unix.xml create mode 100644 tests/qemuxml2argvdata/net-vhostuser.x86_64-2.5.0.args create mode 100644 tests/qemuxml2argvdata/net-vhostuser.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/parallel-unix-chardev.x86_64-2.5.0.args create mode 100644 tests/qemuxml2argvdata/parallel-unix-chardev.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/parallel-unix-chardev.xml create mode 100644 tests/qemuxml2argvdata/smartcard-passthrough-unix.x86_64-2.5.0.args create mode 100644 tests/qemuxml2argvdata/smartcard-passthrough-unix.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/smartcard-passthrough-unix.xml create mode 100644 tests/qemuxml2argvdata/usb-redir-unix.x86_64-2.5.0.args create mode 100644 tests/qemuxml2argvdata/usb-redir-unix.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/usb-redir-unix.xml create mode 100644 tests/qemuxml2argvdata/virtio-rng-egd-unix.x86_64-2.5.0.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-egd-unix.x86_64-latest.args create mode 100644 tests/qemuxml2argvdata/virtio-rng-egd-unix.xml -- 2.16.4 -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list