Re: [PATCH 17/53] vircgroup: introduce virCgroupV2HasEmptyTasks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-10-02 at 10:44 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx>
> ---
>  src/util/vircgroupv2.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/src/util/vircgroupv2.c b/src/util/vircgroupv2.c
> index e7dbace42b..c6a9e0a7df 100644
> --- a/src/util/vircgroupv2.c
> +++ b/src/util/vircgroupv2.c
> @@ -446,6 +446,22 @@ virCgroupV2AddTask(virCgroupPtr group,
>  }
>  
>  
> +static int
> +virCgroupV2HasEmptyTasks(virCgroupPtr cgroup,
> +                         int controller)
> +{
> +    int ret = -1;
> +    VIR_AUTOFREE(char *) content = NULL;
> +

Just a nitpick here. I've noticed that in the v1 you're actually
checking whether cgroup is NULL or not.

Shouldn't you consider doing the same here as well?

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux