On 10/01/2018 01:58 PM, Erik Skultety wrote: > On Mon, Oct 01, 2018 at 12:57:18PM +0200, Fabiano Fidêncio wrote: >> Signed-off-by: Fabiano Fidêncio <fidencio@xxxxxxxxxx> >> --- >> I went through the commits since last release and added a few notes >> which seem to be relevant for the news. >> >> In case you notice there's something missing, please, either send me the >> text to add it (and I'll re-sping this patch) and add the text before >> merging this one. >> >> Changes since v1: >> - Actually run make-check in order to be sure the changes are fine. >> --- >> docs/news.xml | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 69 insertions(+) >> > Now, this is just a matter of preference, you did a good job, but I'd probably > also mention the following: > 09d35afd2c util: file: introduce VIR_AUTOCLOSE macro to close fd of the file automatic Is it something that should interest our users? In my view it's just a matter of our internal implementation. We haven't mention VIR_AUTOFREE() back in the day. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
