Re: [PATCH 0/4] Small changes to virdbus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 9/21/18 9:02 AM, Marc Hartmayer wrote:
> Marc Hartmayer (4):
>   virdbus: Grab a ref as long as the while loop is executed
>   virdbus: Unref the D-Bus connection when closing
>   virdbus: Report a debug message that dbus_watch_handle() has failed
>   virdbus: Use the mnemonic macros for dbus_bool_t values
> 
>  src/util/virdbus.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

(series) and pushed,

John

although /me wonders what happens to @info in virDBusAddWatch when the
call to virEventAddHandle fails, dbus_watch_set_data(watch, NULL, NULL)
is called and the code returns FALSE. I assume it's leaked, different
problem though ;-)

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux