Re: [PATCH v5 07/13] conf: Introduce parser, formatter for uid and fid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2018/9/20 下午4:28, Andrea Bolognani 写道:
On Wed, 2018-09-19 at 16:59 +0800, Yi Min Zhao wrote:
在 2018/9/13 下午9:58, Andrea Bolognani 写道:
I realize now that virPCIDeviceAddressIsValid() and
virPCIDeviceAddressIsEmpty() are *not* in util/virpci, though I
swear that I posted patches moving them over... My bad, I'll do
that right away.

Sorry for the confusion.
Got it.
The patches mentioned above have been posted and merged in the
meantime :)

 From the high level point of view, code outside of conf/ should,
for the most part, not need to concern itself with zPCI at all: it
would eg. ask for a PCI address to be allocated, and if the device
in question can be a zPCI device then a zPCI extension address will
be allocated for it as part of the same function call; the only
part of qemu/ that should care about the zPCI address is the one
generating the relevant command line arguments.

Can you try and see whether this kind of API would work?
I did a simple test. It worked. Do you prefer this way?
Yes please, I'd very much like to see what that looks like and
whether it addresses the problems caused by the ambiguity of the
API we've used until now.

So do you mean we use this kind of API in next version for review?

--
Yi Min

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux