Re: [PATCH 0/6] syntax-check: Introduce a new rule to check misaligned stuff and fix it (batch I)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/19/2018 10:38 AM, Shi Lei wrote:
> This series check misaligned stuff in parenthesis:
> 1. For misaligned arguments of function
> 2. For misaligned conditions of [if|while|switch|...]
> 
> It adds a temporary filter for this new rule since there're
> too much misalignment.
> Now it just fix misalignment in src/util and it's the batch I.
> Next step, we need modify this path filter to finish all changes.
> 
> Also, it simplifies the check-spacing.pl by adding wrapper functions
> before introducing the new rule.
> 
> Thanks,
> 
> Shi Lei
> 
> Shi Lei (6):
>   util: Fix misaligned arguments and misaligned conditions for
>     [if|while|...]
>   build-aux:check-spacing: Add wrapper function of CheckFunctionBody
>   build-aux:check-spacing: Add wrapper function of KillComments
>   build-aux:check-spacing: Add wrapper function of CheckWhiteSpaces
>   build-aux:check-spacing: Add wrapper function of CheckCurlyBrackets
>   build-aux:check-spacing: Introduce a new rule to check misaligned
>     stuff in parenthesises
> 
>  build-aux/check-spacing.pl       | 476 ++++++++++++++++++++-----------
>  src/util/vircgroup.c             |  34 +--
>  src/util/virconf.c               |   4 +-
>  src/util/virdbus.c               |   2 +-
>  src/util/virdnsmasq.c            |   5 +-
>  src/util/virerror.c              |   2 +-
>  src/util/virevent.c              |  14 +-
>  src/util/vireventpoll.c          |   8 +-
>  src/util/virfile.c               |   6 +-
>  src/util/virgic.c                |   2 +-
>  src/util/virhook.c               |   2 +-
>  src/util/virhostdev.c            |  23 +-
>  src/util/viridentity.c           |  18 +-
>  src/util/viriscsi.c              |  22 +-
>  src/util/virjson.c               |   2 +-
>  src/util/virkeycode.c            |  22 +-
>  src/util/virkeyfile.c            |   6 +-
>  src/util/virlockspace.c          |   2 +-
>  src/util/virlog.c                |  18 +-
>  src/util/virnetdev.c             |   4 +-
>  src/util/virnetdevbridge.c       |   2 +-
>  src/util/virnetdevip.c           |  11 +-
>  src/util/virnetdevmacvlan.c      |  30 +-
>  src/util/virnetdevopenvswitch.c  |  34 +--
>  src/util/virnetdevvportprofile.c |  24 +-
>  src/util/virnetlink.c            |  10 +-
>  src/util/virobject.c             |   2 +-
>  src/util/virpci.c                |   4 +-
>  src/util/virperf.c               |   4 +-
>  src/util/virprocess.c            |   2 +-
>  src/util/virqemu.c               |   4 +-
>  src/util/virresctrl.c            |   7 +-
>  src/util/virsocketaddr.c         |   2 +-
>  src/util/virstorageencryption.c  |   2 +-
>  src/util/virstoragefile.c        |  60 ++--
>  src/util/virsysinfo.c            |   2 +-
>  src/util/viruri.c                |   2 +-
>  src/util/virutil.c               |   2 +-
>  src/util/virxml.c                |   2 +-
>  39 files changed, 512 insertions(+), 366 deletions(-)
> 

Yay! ACKed and pushed.

We definitely want more of these.

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux