The function performing the checks, rather than its callers,
should contain comments explaining the rationale behind said
checks.
Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
---
src/qemu/qemu_capabilities.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index 04c2adcfb5..e14da5acab 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -631,15 +631,19 @@ bool
virQEMUCapsGuestIsNative(virArch host,
virArch guest)
{
+ /* host & guest arches match */
if (host == guest)
return true;
+ /* hostarch is x86_64 and guest arch is i686 (needs -cpu qemu32) */
if (host == VIR_ARCH_X86_64 && guest == VIR_ARCH_I686)
return true;
+ /* hostarch is aarch64 and guest arch is armv7l (needs -cpu aarch64=off) */
if (host == VIR_ARCH_AARCH64 && guest == VIR_ARCH_ARMV7L)
return true;
+ /* hostarch and guestarch are both ppc64 */
if (ARCH_IS_PPC64(host) && ARCH_IS_PPC64(guest))
return true;
@@ -753,12 +757,6 @@ virQEMUCapsInitGuest(virCapsPtr caps,
}
}
- /* qemu-kvm/kvm binaries can only be used if
- * - host & guest arches match
- * - hostarch is x86_64 and guest arch is i686 (needs -cpu qemu32)
- * - hostarch is aarch64 and guest arch is armv7l (needs -cpu aarch64=off)
- * - hostarch and guestarch are both ppc64*
- */
if (virQEMUCapsGuestIsNative(hostarch, guestarch)) {
const char *kvmbins[] = {
"/usr/libexec/qemu-kvm", /* RHEL */
--
2.17.1
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
