There are a few cases in which we're not reporting the correct
information through 'virsh capabilities', leading to applications
such as libguestfs attempting to launch KVM guests on a host that
doesn't actually support them.
Our code is also more complicated than it needs to be due to
backwards compatibilty reasons that we no longer care about these
days, so we can perform some cleanup there; there are further
cleanup opportunities in the same area, but some of them are a
bit tricky so I'll leave them for a follow-up series.
We also get some extra test coverage pretty much for free. Yay!
Andrea Bolognani (5):
tests: Reuse qemucapabilities data for qemucaps2xml
tests: Add more tests to qemucaps2xml
qemu: Drop QEMU_CAPS_ENABLE_KVM
qemu: Clarify QEMU_CAPS_KVM
qemu: Don't check for /dev/kvm presence
src/qemu/qemu_capabilities.c | 27 +---
src/qemu/qemu_capabilities.h | 4 +-
tests/qemucapabilitiestest.c | 1 +
tests/qemucaps2xmldata/all_1.6.0-1.caps | 129 ------------------
.../nodisksnapshot_1.6.0-1.caps | 128 -----------------
.../caps_1.5.3.x86_64.xml} | 12 +-
.../caps_1.6.0.x86_64.xml} | 14 +-
.../caps_1.7.0.x86_64.xml} | 12 +-
.../caps_2.1.1.x86_64.xml} | 12 +-
.../caps_2.10.0.aarch64.xml} | 13 +-
.../caps_2.10.0.ppc64.xml} | 14 +-
.../caps_2.10.0.s390x.xml} | 14 +-
.../caps_2.10.0.x86_64.xml} | 12 +-
.../caps_2.11.0.s390x.xml} | 14 +-
.../caps_2.11.0.x86_64.xml} | 12 +-
.../caps_2.12.0.aarch64.xml} | 13 +-
.../caps_2.12.0.ppc64.xml} | 14 +-
.../caps_2.12.0.s390x.xml} | 14 +-
.../caps_2.12.0.x86_64.xml} | 12 +-
.../caps_2.4.0.x86_64.xml} | 12 +-
.../caps_2.5.0.x86_64.xml} | 12 +-
.../caps_2.6.0.aarch64.xml} | 13 +-
.../caps_2.6.0.ppc64.xml} | 14 +-
.../caps_2.6.0.x86_64.xml} | 12 +-
.../caps_2.7.0.s390x.xml} | 14 +-
.../caps_2.7.0.x86_64.xml} | 12 +-
.../caps_2.8.0.s390x.xml} | 14 +-
.../caps_2.8.0.x86_64.xml} | 12 +-
.../caps_2.9.0.ppc64.xml} | 14 +-
.../caps_2.9.0.s390x.xml} | 14 +-
.../caps_2.9.0.x86_64.xml} | 12 +-
.../caps_3.0.0.ppc64.xml} | 14 +-
.../caps_3.0.0.riscv32.xml} | 13 +-
.../caps_3.0.0.riscv64.xml | 25 ++++
.../caps_3.0.0.x86_64.xml} | 12 +-
tests/qemucaps2xmltest.c | 63 +++++++--
tests/qemuxml2argvtest.c | 11 +-
37 files changed, 229 insertions(+), 535 deletions(-)
delete mode 100644 tests/qemucaps2xmldata/all_1.6.0-1.caps
delete mode 100644 tests/qemucaps2xmldata/nodisksnapshot_1.6.0-1.caps
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_1.5.3.x86_64.xml} (67%)
rename tests/{qemucaps2xmldata/nodisksnapshot_1.6.0-1.xml => qemucaps2xmloutdata/caps_1.6.0.x86_64.xml} (60%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_1.7.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.1.1.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.10.0.aarch64.xml} (62%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.10.0.ppc64.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.10.0.s390x.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.10.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.11.0.s390x.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.11.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.12.0.aarch64.xml} (62%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.12.0.ppc64.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.12.0.s390x.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.12.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.4.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.5.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.6.0.aarch64.xml} (62%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.6.0.ppc64.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.6.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.7.0.s390x.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.7.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.8.0.s390x.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.8.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.9.0.ppc64.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.9.0.s390x.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_2.9.0.x86_64.xml} (67%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_3.0.0.ppc64.xml} (56%)
copy tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_3.0.0.riscv32.xml} (54%)
create mode 100644 tests/qemucaps2xmloutdata/caps_3.0.0.riscv64.xml
rename tests/{qemucaps2xmldata/all_1.6.0-1.xml => qemucaps2xmloutdata/caps_3.0.0.x86_64.xml} (67%)
--
2.17.1
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
