Re: [PATCH v5 03/13] conf: Introduce a new PCI address extension flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2018-09-04 at 16:39 +0800, Yi Min Zhao wrote:
[...]
> @@ -164,6 +164,7 @@ struct _virDomainDeviceInfo {
>       * assignment, never saved and never reported.
>       */
>      int pciConnectFlags; /* enum virDomainPCIConnectFlags */
> +    int pciAddressExtFlags; /* enum virDomainPCIAddressExtensionFlags */

There's a comment right above this that explains how pciConnectFlags
is only used during address assignment: you should amend it to
mention pciAddressExtFlags too.

Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux