While looking at how slow this test has gotten,
I found a lost test case, some redundancies.
Thankfully, not running the HostModel functions
twice helped, but there is still room for improvement:
we spend a lot of time in the CPU driver comparing
the same strings over and over again and with over 300
entries in virQEMUCaps enum, we can reduce some of these
string comparisons in the future to cope with more
and more QEMU versions being tested.
Ján Tomko (9):
tests: drop 'drive' from qemuxml2startup tests
tests: add macro for dealing with exclusive flags
tests: introduce macro for qemu XML->startup XML
tests: only run startup XML tests if requested
tests: report errors in QEMU XML->startup XML tests
tests: drop redundant virQEMUCapsFilterByMachineType
tests: do not mangle real qemu caps in xml2argvtest
tests: turn skipLegacyCPUs into a flag
qemu: remove unnecessary virQEMUCapsFreeHostCPUModel
src/qemu/qemu_capabilities.c | 25 +------
src/qemu/qemu_capspriv.h | 5 --
tests/qemuxml2argvtest.c | 76 +++++++++++++---------
.../{disk-drive-shared.xml => disk-shared.xml} | 0
4 files changed, 49 insertions(+), 57 deletions(-)
rename tests/qemuxml2startupxmloutdata/{disk-drive-shared.xml => disk-shared.xml} (100%)
--
2.16.4
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
