Re: [libvirt-snmp][PATCH 3/3] configure: Prevent autoreconf from installing `compile' file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



s/Prevent autoreconf from installing `compile' file/Modernize/

On Wed, Sep 05, 2018 at 10:55:40AM +0200, Michal Privoznik wrote:
When running autoreconf, it installs this `compile' file which

s/installs/creates/ maybe?

I'd expect 'install' to refer to the process of copying the resulting
files into the system by 'make install'

triggers my OCD. It appears that our configure script can be
modernized a bit which makes it stop.

It merely puts them into the requested AUX_DIR


Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
---
configure.ac | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index f520927..c8df41d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,8 +1,12 @@
AC_INIT([libvirt-snmp],[0.0.3],[libvir-list@xxxxxxxxxx],[],[http://libvirt.org])
-AM_INIT_AUTOMAKE([-Wall -Werror])
+AC_CONFIG_SRCDIR(src/libvirtSnmp.c)
+AC_CONFIG_AUX_DIR([build-aux])
AC_CONFIG_HEADERS([config.h])
+AM_INIT_AUTOMAKE([-Wall -Werror])

Not moving this line would make the diff smaller.


-AC_PREREQ([2.50])

+AC_CANONICAL_HOST

Not necessary, 'host' is not used anywhere.

+
+AM_SILENT_RULES([yes])


Without the AM_INIT_AUTOMAKE and AC_CANONICAL_HOST changes:

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux