On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: > > If no JSON parser is available qemublocktest fails, so skip its execution. > > > > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> > > --- > > > > Pushed as a build fix for platforms without JSON parser installed > > Which platforms? All machines in our CI environments should have > yajl installed. It wasn't CI - it was my own FreeBSD machine without yajl > Either way, IIRC during the switch to Jansson we also made the > JSON parser mandatory when building the QEMU driver, a change > which I believe we might have reverted when switching back to > yajl: can we just have that back? Or are there some issues > preventing us from doing so? All our other tests have WITH_YAJL checks in them, this one was the exception. Possibly they could all be changed with WITH_QEMU instead but that's more than I want todo as a build fix. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
