Re: [PATCH 2/6] conf: Move virDomainDeviceAddressIsValid() to device_conf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 31, 2018 at 04:00:43PM +0200, Andrea Bolognani wrote:
The function is called on a virDomainDeviceInfo, so it
should be declared along with it.

Moving this function requires moving and making public
virDomainDeviceCCWAddressIsValid() as well, but that's
perfectly fine since the same reasoning above also
applies to it, due to virDomainDeviceCCWAddress being
(correctly) declared in device_conf.

Signed-off-by: Andrea Bolognani <abologna@xxxxxxxxxx>
---
src/conf/device_conf.c   | 36 ++++++++++++++++++++++++++++++++++++
src/conf/device_conf.h   |  5 +++++
src/conf/domain_conf.c   | 36 ------------------------------------
src/conf/domain_conf.h   |  2 --
src/libvirt_private.syms |  3 ++-
5 files changed, 43 insertions(+), 39 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux