Re: [PATCH] vsh-table: Fix broken build on centos and rhel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 29, 2018 at 09:48:10AM +0200, Simon Kobyda wrote:
> The reason of broken build was that centos and rhel use older version of glibc.
> These versions of glibc on these platforms cannot work with newer unicodes,
> therefore functions iswprint() and wcwidth() failed. So I replaced them with
I'll rephrase ^this as follows:

thus causing functions x y return unexpected values causing the vshtabletest to
fail. Therefore, let's replace the new unicode characters causing issues with
some older ones to fix the test suite, as the issue would still persist during
runtime.

> older unicode characters.
>
> Signed-off-by: Simon Kobyda <skobyda@xxxxxxxxxx>
> ---

In this case a link to your travis proving the fix would be helpful, but since
I've already seen it personally:

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux