On 08/15/2018 05:18 AM, Peter Krempa wrote: > Add a new modifier character which will select given schema entry only > when it is optional. > So when the object has a "*" modifier, then we need to ...? And the check for the "default" key means what? Is it only ever present when "*" is the modifier? I bet I learn in subsequent patches, but I'm going 1 by 1. > Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx> > --- > src/qemu/qemu_qapi.c | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 deletions(-) > Please just fill in the above details - as it's not "obvious" to this reader, but I don't believe the code is wrong, so... Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
