Re: [PATCH v3 6/9] qemu: add qemuDomainAssignVirtioMMIOAddresses()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-08-22 at 11:15 +0200, Lubomir Rintel wrote:

A short not explaining why you need to do this, along the lines of

  We're going to need to assign virtio-mmio addresses to non-ARM
  guests soon, so let's create a generic wrapper that calls to
  the architecture-specific implementation.

sure would be nice... Are you okay with me adding it to the commit
message before pushing?

Either way the code is fine, so

  Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>

-- 
Andrea Bolognani / Red Hat / Virtualization

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux