Re: [PATCH v3 01/12] conf: Add definitions for 'uid' and 'fid' PCI address attributes

[Yi Min Zhao <zyimin@xxxxxxxxxxxxx>]

在 2018/8/23 下午4:12, Andrea Bolognani 写道:
> Exactly. You can either just add zpci_uid and zpci_fid to the
> virPCIDeviceAddress struct, or have
>
>    struct _virZPCIDeviceAddress {
>        unsigned int uid;
>        unsigned int fid;
>    };
>
>    struct _virPCIDeviceAddress {
>        unsigned int domain;
>        unsigned int bus;
>        unsigned int slot;
>        unsigned int function;
>        int multi; /* virTristateSwitch */
>        virZPCIDeviceAddress zpci;
>    };
There's an error in syntax-check. I think it's from common code.

src/util/virpci.h:47:    unsigned int uid;
maint.mk: use pid_t for pid, uid_t for uid, gid_t for gid

I think it mistakes zpci's uid.

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list