Em seg, 20 de ago de 2018 às 23:35, Julio Faracco
<jcfaracco@xxxxxxxxx> escreveu:
>
> This commit implements the function qemuAgentGetHostname() that uses the
> QEMU command 'guest-get-host-name' to retrieve the guest hostname of
> Virtual Machine. It is a possibility where QEMU-GA is running.
>
> Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx>
> ---
> src/qemu/qemu_agent.c | 42 ++++++++++++++++++++++++++++++++++++++++++
> src/qemu/qemu_agent.h | 4 ++++
> 2 files changed, 46 insertions(+)
>
> diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c
> index bf08871f18..2d006b8070 100644
> --- a/src/qemu/qemu_agent.c
> +++ b/src/qemu/qemu_agent.c
> @@ -1682,6 +1682,48 @@ qemuAgentUpdateCPUInfo(unsigned int nvcpus,
> return 0;
> }
>
> +int
> +qemuAgentGetHostname(qemuAgentPtr mon,
> + char **hostname)
> +{
> + int ret = -1;
> + virJSONValuePtr cmd;
> + virJSONValuePtr reply = NULL;
> + virJSONValuePtr data = NULL;
> +
> + cmd = qemuAgentMakeCommand("guest-get-host-name",
> + NULL);
> +
> + if (!cmd)
> + return ret;
> +
> + if (qemuAgentCommand(mon, cmd, &reply, true,
> + VIR_DOMAIN_QEMU_AGENT_COMMAND_BLOCK) < 0)
> + goto cleanup;
> +
> + if (qemuAgentCheckError(cmd, reply) < 0)
> + goto cleanup;
There is no need to check error here. This function is already being executed
inside qemuAgentCommand(). This is redundant.
> +
> + if (!(data = virJSONValueObjectGet(reply, "return"))) {
> + virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> + _("malformed return value"));
> + goto cleanup;
> + }
> +
> + if (VIR_STRDUP(*hostname,
> + virJSONValueObjectGetString(data, "host-name")) <= 0) {
> + virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
> + _("'host-name' missing in reply of guest-get-host-name"));
> + goto cleanup;
> + }
> +
> + ret = 0;
> +
> + cleanup:
> + virJSONValueFree(cmd);
> + virJSONValueFree(reply);
> + return ret;
> +}
>
> int
> qemuAgentGetTime(qemuAgentPtr mon,
> diff --git a/src/qemu/qemu_agent.h b/src/qemu/qemu_agent.h
> index 6dd9c702dd..4354b7e0cf 100644
> --- a/src/qemu/qemu_agent.h
> +++ b/src/qemu/qemu_agent.h
> @@ -105,6 +105,10 @@ int qemuAgentUpdateCPUInfo(unsigned int nvcpus,
> qemuAgentCPUInfoPtr cpuinfo,
> int ncpuinfo);
>
> +int
> +qemuAgentGetHostname(qemuAgentPtr mon,
> + char **hostname);
> +
> int qemuAgentGetTime(qemuAgentPtr mon,
> long long *seconds,
> unsigned int *nseconds);
> --
> 2.17.1
>
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
