On Mon, 2018-08-20 at 18:52 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1610072 > > Due to historical reasons we were not parsing device info on You spelled "hysterical raisins" wrong ;) [...] > - if (def->deviceType == VIR_DOMAIN_CHR_DEVICE_TYPE_CHANNEL && > - def->targetType == VIR_DOMAIN_CHR_CHANNEL_TARGET_TYPE_GUESTFWD) { > - VIR_DEBUG("Ignoring device address for gustfwd channel"); > - } else if (virDomainDeviceInfoParseXML(xmlopt, node, > - &def->info, flags) < 0) { > + if (virDomainDeviceInfoParseXML(xmlopt, node, &def->info, flags) < 0) > goto error; > - } > - I agree that fixing Bug 1610072 is more important than preventing Bug 1172526 from showing up again, but it would be great if we could make it so both are fixed... How about parsing the info and then clearing out the address only if it's a guestfwd channel? The existing virDomainDeviceInfoClear() is a bit too thorough, but perhaps you can introduce a new virDomainDeviceInfoClearAddress() that only zeroes out the address and use that here. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
