On Fri, Aug 10, 2018 at 10:38:10AM +0100, Daniel P. Berrangé wrote: > On Fri, Aug 10, 2018 at 11:29:30AM +0200, Michal Privoznik wrote: > > G_ADD_PRIVATE was added in 2.38 and older functions are getting deprecated: > > https://gitlab.gnome.org/GNOME/glib/merge_requests/7/commits > > Our min glib2 version is currently 2.36, since that's what RHEL-7 has. > > So this change would have to increase the min required version too. We could use some compat magic without making it too horrible: #if GLIB_CHECK_VERSION(2, 38, 0) #define G_TYPE_ADD_PRIVATE(klass, typ) \ (void)klass; #else #define G_TYPE_ADD_PRIVATE(klass, typ) \ g_type_class_add_private(klass, sizeof(GVirConfigDomainChardevSourcePtyPrivate)); #define G_DEFINE_TYPE_WITH_PRIVATE(a, b, c) \ G_DEFINE_TYPE(a, b, c) #endif Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
