On Sat, Jul 28, 2018 at 11:31:44PM +0530, Sukrit Bhatnagar wrote:
> By making use of GNU C's cleanup attribute handled by the
> VIR_AUTOFREE macro for declaring scalar variables, majority
> of the VIR_FREE calls can be dropped, which in turn leads to
> getting rid of most of our cleanup sections.
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@xxxxxxxxx>
> ---
> src/util/virprocess.c | 49 ++++++++++++++++++++++++-------------------------
> 1 file changed, 24 insertions(+), 25 deletions(-)
>
...
> @@ -271,11 +270,10 @@ virProcessWait(pid_t pid, int *exitstatus, bool raw)
>
> error:
> {
> - char *st = virProcessTranslateStatus(status);
> + VIR_AUTOFREE(char *) st = virProcessTranslateStatus(status);
I also moved the declaration at the function block level, thus being able to
drop the curly braces, as that's a style we don't use anymore.
Erik
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
