On 08/01/2018 12:47 PM, Peter Krempa wrote: > On Wed, Aug 01, 2018 at 12:40:14 +0200, Michal Privoznik wrote: >> On 07/31/2018 07:19 PM, Ján Tomko wrote: >>> And I'm still unsure about leaving in >>> commit 55ce65646348884656fd7bf3f109ebf8f7603494 >>> qemu: Use the correct vm def on cold attach >>> https://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=55ce6564634 >>> Which means attach-device --live --config will attach an interface >>> with a different MAC address in live and persistent definition. Laine? >>> >> >> Well, It's not only MAC address that can change. The device address >> might change too. This points to a broader problem. When we are parsing >> a device XML we fill in the blanks in postParse callbacks. However, >> those look only at either live or at inactive XML. Not at both at the >> same time. So how can we fill in the blanks that would be valid for both >> XMLs? > > We can fill in the definition and then copy it and validate it > afterwards. That way the blanks are filled and we can then validate that > it fits into the other definition. The description here sounds that in > this release we made things worse than it was before though. But that might fail. For instance, we generate a PCI for a hot plugged device based on say live XML, but the address is already taken in config XML. I'm not sure if there's an easy way out of this. And regarding the revert - I guess it's just a matter of somebody posting the patch. Michal -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
