Pino Toscano <ptoscano@xxxxxxxxxx> [2018-08-01, 03:08PM +0200]: > viriscsitest tries to ensure the interface IQN used is a specific one, > checking later on that it is the same all during the whole test. Since > the IQN generation involves random bytes, viriscsitest got a fake > virRandomBytes from the virrandommock helper library, setting static > values. virRandomBits(), called by virStorageBackendCreateIfaceIQN(), > always requests 8 random bytes, chopping off the ones not requested by > the caller -- this meant that on big endian machines it would chop bytes > from the wrong size of the data buffer, and thus not returning the > expected numbers. > > As a fix, do not rely on the mock virRandomBytes, but provide an own > version of it: this version will fill the values in the expected order, > depending on the endianness of the system. This way, the result of > virStorageBackendCreateIfaceIQN() will be what the test actually > expects. > > Signed-off-by: Pino Toscano <ptoscano@xxxxxxxxxx> Tested-by: Bjoern Walk <bwalk@xxxxxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature
-- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
