Re: [PATCH for 4.6.0] tests: qemucapsprobe: Fix output after swithching to jansson

Yi Min Zhao <zyimin@xxxxxxxxxxxxx> · Tue, 31 Jul 2018 17:42:50 +0800

在 2018/7/30 下午11:12, Peter Krempa 写道:
Jansson does not put a newline at the end of formatted JSON strings.
This breaks the qemucapsprobe utility as we need to keep the spacing so
that tests work. Add an explicit newline.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
  tests/qemucapsprobemock.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/tests/qemucapsprobemock.c b/tests/qemucapsprobemock.c
index 5936975505..049b16273a 100644
--- a/tests/qemucapsprobemock.c
+++ b/tests/qemucapsprobemock.c
@@ -76,6 +76,7 @@ qemuMonitorSend(qemuMonitorPtr mon,
          printLineSkipEmpty("\n", stdout);

      printLineSkipEmpty(reformatted, stdout);
+    printLineSkipEmpty("\n", stdout);
      VIR_FREE(reformatted);

      return realQemuMonitorSend(mon, msg);
@@ -116,6 +117,7 @@ qemuMonitorJSONIOProcessLine(qemuMonitorPtr mon,
              printLineSkipEmpty("\n", stdout);

          printLineSkipEmpty(json, stdout);
+        printLineSkipEmpty("\n", stdout);
      }

   cleanup:
I have a question. Could this problem(I mean miss \n) trigger 
qemuxml2*test can't run?

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list







