On Mon, 2018-07-30 at 11:47 +0100, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
A quick note in the commit message explaining why this change is
necessary would certainly be nice.
[...]
> - autotools-rpm-job:
> parent_jobs: 'virt-viewer-master-check'
> - machines: '{rpm_machines}'
> + machines:
> + - libvirt-fedora-28
> + - libvirt-fedora-rawhide
Please use spaces instead of tabs for indentation: in addition to
the usual consistency concerns, I don't think your version would
work at all.
With at least the indentation issues fixed,
Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
--
Andrea Bolognani / Red Hat / Virtualization
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
