Re: [PATCH for 4.6.0 0/3] Revert VIR_AUTOPTR work in cgroup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 30, 2018 at 11:19:32AM +0200, Michal Privoznik wrote:
> Turns out, our code relies on virCgroupFree(&var) setting
> var = NULL. Otherwise a double free can occur:
> 
> https://www.redhat.com/archives/libvir-list/2018-July/msg02004.html
> 
> Rather than inserting var = NULL after each virCgroupFree() call lets
> revert the patches. The ideal solution would be to use virCgroupFree
> both directly and as attribute cleanup.
> 
> Michal Prívozník (3):
>   Revert "util: cgroup: use VIR_AUTOPTR for aggregate types"
>   Revert "util: cgroup: define cleanup function using
>     VIR_DEFINE_AUTOPTR_FUNC"
>   Revert "util: cgroup: modify virCgroupFree to take virCgroupPtr"

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux