Re: [jenkins-ci PATCH] hosts_vars: drop virt-viewer from platforms with old spice-gtk

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 30, 2018 at 12:17:56PM +0200, Andrea Bolognani wrote:
> On Mon, 2018-07-30 at 10:04 +0100, Daniel P. Berrangé wrote:
> > git master requires spice-gtk >= 0.35
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> > ---
> >  guests/host_vars/libvirt-centos-7/main.yml        | 1 -
> >  guests/host_vars/libvirt-debian-8/main.yml        | 1 -
> >  guests/host_vars/libvirt-debian-9/main.yml        | 1 -
> >  guests/host_vars/libvirt-debian-sid/main.yml      | 1 -
> >  guests/host_vars/libvirt-fedora-27/main.yml       | 1 -
> >  guests/host_vars/libvirt-freebsd-10/main.yml      | 1 -
> >  guests/host_vars/libvirt-freebsd-11/main.yml      | 1 -
> >  guests/host_vars/libvirt-freebsd-current/main.yml | 1 -
> >  guests/host_vars/libvirt-ubuntu-14/main.yml       | 1 -
> >  guests/host_vars/libvirt-ubuntu-16/main.yml       | 1 -
> >  guests/host_vars/libvirt-ubuntu-18/main.yml       | 1 -
> >  11 files changed, 11 deletions(-)
> 
> All FreeBSD versions have 0.35, so they shouldn't be dropped;
> Debian Sid is still on 0.34, but I expect it will get 0.35 at
> some point in the not-too-distant future so I wouldn't touch
> that either, since it doesn't affect CentOS CI either way.
> 
> More importantly: do we really want to stop building virt-viewer
> entirely on those platform just because a recent enough spice-gtk
> version is not available? Building without spice support still
> provides some amount of coverage (eg. VNC support), and the builds
> themselves don't fail, so I don't really see the upside of merging
> this.
> 
> My suggestion would be to just disable the virt-viewer-master-rpm
> job on Fedora 27 and CentOS 7 and call it a day.

Sigh, yes, I'm not thinking properly yet this morning 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux