Re: [dbus PATCH 1/2] tests: {interface, node_device}_create should be used as setup fixtures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 26, 2018 at 02:09:57PM +0200, Katerina Koukiou wrote:
* node_device_create was a fixture but we were calling it as normal function,
thus it got triggered twice.
* interface_create was not a fixture.

This patch makes sure that the setup work these two functions are doing, will
run before the actual test call phase.

Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx>
---
tests/libvirttest.py    |  1 +
tests/test_connect.py   |  9 +++++----
tests/test_interface.py | 22 ++++++++++++----------
tests/test_nodedev.py   | 16 ++++++++--------
4 files changed, 26 insertions(+), 22 deletions(-)


Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux