On Wed, Jul 25, 2018 at 03:02:08PM +0200, Michal Privoznik wrote:
> There are two places where we report supported sizes of huge pages:
>
> /capabilities/host/cpu/pages
> /capabilities/host/topology/cells/cell/pages
>
> The former aggregates sizes over all NUMA nodes while the latter
> reports supported sizes only for given node. While we are
> reporting per NUMA node sizes we are not reporting the aggregated
> sizes. I've noticed this when wondering why doesn't allocpages
> completer work.
>
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> src/lxc/lxc_conf.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/lxc/lxc_conf.c b/src/lxc/lxc_conf.c
> index 5cd6f231dd..949bfe246a 100644
> --- a/src/lxc/lxc_conf.c
> +++ b/src/lxc/lxc_conf.c
> @@ -86,6 +86,10 @@ virCapsPtr virLXCDriverCapsInit(virLXCDriverPtr driver)
> if (driver && virNodeSuspendGetTargetMask(&caps->host.powerMgmt) < 0)
> VIR_WARN("Failed to get host power management capabilities");
>
> + /* Add huge pages info */
> + if (virCapabilitiesInitPages(caps) < 0)
> + VIR_WARN("Failed to get pages info");
> +
> if (virGetHostUUID(caps->host.host_uuid)) {
> virReportError(VIR_ERR_INTERNAL_ERROR,
> "%s", _("cannot get the host uuid"));
Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>
--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list
