Re: [PATCH v1 08/40] util: cgroup: define cleanup function using VIR_DEFINE_AUTOPTR_FUNC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jul 21, 2018 at 05:36:40PM +0530, Sukrit Bhatnagar wrote:
> Using the new VIR_DEFINE_AUTOPTR_FUNC macro defined in
> src/util/viralloc.h, define a new wrapper around an existing
> cleanup function which will be called when a variable declared
> with VIR_AUTOPTR macro goes out of scope. Also, drop the redundant
> viralloc.h include, since that has moved from the source module into
> the header.
>
> When a variable of type virCgroupPtr is declared using
> VIR_AUTOPTR, the function virCgroupFree will be run
> automatically on it when it goes out of scope.
>
> This commit also adds an intermediate typedef for virCgroup type
> for use with the cleanup macros by renaming the struct in
> src/util/vircgrouppriv.h from virCgroup to _virCgroup.

How about: ... typedef to virCgroup type in order to make use of the
VIR_DEFINE_AUTOPTR_FUNC macro.

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux