On Tue, 2018-07-10 at 16:02 +0800, Yi Min Zhao wrote: > struct _virPCIDeviceAddress { > unsigned int domain; > unsigned int bus; > unsigned int slot; > unsigned int function; > int multi; /* virTristateSwitch */ > + virZPCIDeviceAddressPtr zpci; This should probably be an embedded structure rather than a pointer to a separate, heap allocated structure. I remember Laine having somewhat strong feelings about the topic, so I'll leave arguing for or against that to him :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list