Re: [PATCH 2/2] docs: formatdomain: clarify period cputune subelement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 17, 2018 at 05:47:32PM +0200, Katerina Koukiou wrote:
Although the name of the element is not self-explanatory,
it's affecting only the vcpu threads.

Signed-off-by: Katerina Koukiou <kkoukiou@xxxxxxxxxx>
---
docs/formatdomain.html.in | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
index 7fa448acdc..61930e4907 100644
--- a/docs/formatdomain.html.in
+++ b/docs/formatdomain.html.in
@@ -831,11 +831,11 @@
      <dd>
        The optional <code>quota</code> element specifies the maximum allowed
        bandwidth(unit: microseconds). A domain with <code>quota</code> as any

There is a missing space before the parenthesis here, and it's copied
multiple times for all the similar attributes. It's a good indicator
that we should only write the repetititive text once, and collect the
differences in a neat table, e.g.:

+---------------+----------------+---------+-------------------------+
+ quota element | period element | affects | since                   |
+---------------+----------------+---------+-------------------------+
+ quota         | period         | vCPUs   | 0.9.4, LXC since 0.9.10 |
+ global_guota  | global_period  | all     | ...                     |
+---------------+----------------+---------+-------------------------+

(But, of course, even this change is better than nothing)

Jano

-        negative value indicates that the domain has infinite bandwidth, which
-        means that it is not bandwidth controlled. The value should be in range
-        [1000, 18446744073709551] or less than 0. A quota with value 0 means no
-        value. You can use this feature to ensure that all vcpus run at the same
-        speed.

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux