On Tue, 2018-07-17 at 11:16 +0200, Katerina Koukiou wrote: > On Thu, Jul 12, 2018 at 05:19:19PM +0200, Andrea Bolognani wrote: > > +# This is necessary to maintain Python 2.7 compatibility > > +try: > > + import configparser > > +except ImportError: > > + import ConfigParser as configparser > > This import is unused here. Maybe we can introduce it at the point we > actually start using it? That was the intention, but I apparently messed up during rebase :) [...] > I am not very good with python myself, however whenever I am using it I > try to follow coding style standards enforced by pep8 (currently renamed > pycodestyle). > > So here is the output of pep8 for this script, feel free to ignore it if > you don't agree though I encourage that we enforce pep8 for the python > scripts here. I don't necessarily like PEP8 (especially the part about using key=value for keyword arguments, eww) but it's an accepted standard with nice tooling built around it, so I agree we should strive for compilance. -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
