Re: [PATCH] util: remove unused variable inside virFileReadValueString().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



  Julio Faracco wrote:

> The commit 69b937f0358 introduced VIR_AUTOFREE and this macro removed
> VIR_FREE. This change showed that 'str' variable was not being used
> inside this method. This commit removes this unused variable.
> 
> Signed-off-by: Julio Faracco <jcfaracco@xxxxxxxxx>
> ---
>  src/util/virfile.c | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Roman Bogorodskiy <bogorodskiy@xxxxxxxxx>

And pushed.

> diff --git a/src/util/virfile.c b/src/util/virfile.c
> index 6b94885a87..1faeebbdb5 100644
> --- a/src/util/virfile.c
> +++ b/src/util/virfile.c
> @@ -4228,7 +4228,6 @@ int
>  virFileReadValueString(char **value, const char *format, ...)
>  {
>      int ret;
> -    VIR_AUTOFREE(char *) str = NULL;
>      VIR_AUTOFREE(char *) path = NULL;
>      va_list ap;
>  
> -- 
> 2.17.1
> 
> --
> libvir-list mailing list
> libvir-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libvir-list

Roman Bogorodskiy

Attachment: signature.asc
Description: PGP signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux