On Tue, Jul 10, 2018 at 04:09:38PM +0100, Peter Maydell wrote: > On 10 July 2018 at 15:22, Cornelia Huck <cohuck@xxxxxxxxxx> wrote: > > On Tue, 10 Jul 2018 07:59:15 +0200 > > Markus Armbruster <armbru@xxxxxxxxxx> wrote: > > > >> In addition to actively pulling libvirt developers into review of > >> deprecation patches, we should pursue the idea to optionally let QEMU > >> fail on use of deprecated features, then have libvirt run its test suite > >> that way. > > > > What about the following: > > > > qemu_deprecated_option("old_option", "modern_option"); > > > > Which would then print (in normal operation) > > > > "WARNING: 'old_option' is deprecated and will be removed; use 'modern_option' instead" > > > > to the monitor (or to stderr? to both?). > > > > If you start QEMU with a -no-deprecated-options switch, it would print > > > > "ERROR: 'old_option' is deprecated and will be removed; use 'modern_option' instead" > > I'd prefer to see more hand-tailored deprecation messages that can > be more detailed about exactly what the new syntax needs to be. > The ideal would be if you could get right down to the detailed > level of "replace -old_thing -with_foo=x with -device new_thing,foo=x"... Agreed, the more detail we can provide the better for users. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list