Re: [dbus PATCH v2] gitignore: add tests/.pytest_cache

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 07/10/2018 11:13 AM, Andrea Bolognani wrote:
> On Tue, 2018-07-10 at 10:00 -0400, Anya Harter wrote:
>> gitignore: add tests/.pytest_cache
>>
>> Signed-off-by: Anya Harter <aharter@xxxxxxxxxx>
> 
> The commit message should have been adjusted - you're ignoring
> all .pytest_cache/ directories now, not just the one in tests/ :)
> 
> [...]
>> @@ -44,3 +44,4 @@ vgcore.*
>>  /src/org.libvirt.service
>>  
>>  /tests/test_util
>> +**/.pytest_cache
> 
> From gitignore(5):
> 
>   A leading "**" followed by a slash means match in all
>   directories. For example, "**/foo" matches file or directory
>   "foo" anywhere, the same as pattern "foo".
> 
> So the first three characters are entirely unnecessary here: I've
> dropped them, moved the pattern further up in the file (among all
> other non-directory-specific patterns), fixed the commit message,
> added my
> 
>   Reviewed-by: Andrea Bolognani <abologna@xxxxxxxxxx>
> 
> and pushed the commit.
Sorry, I'm still pretty new to .gitignore files. :)

Thanks!

Anya

> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux