Re: [PATCH v3 06/35] util: string: introduce typedef for string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 30, 2018 at 02:30:10PM +0530, Sukrit Bhatnagar wrote:
> Alias virString to (char *) so that the new cleanup macros
> can be used for a list of strings (char **).
>
> Signed-off-by: Sukrit Bhatnagar <skrtbhtngr@xxxxxxxxx>
> ---
>  src/util/virstring.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/util/virstring.h b/src/util/virstring.h
> index 607ae66..ac930fd 100644
> --- a/src/util/virstring.h
> +++ b/src/util/virstring.h
> @@ -26,6 +26,8 @@
>
>  # include "internal.h"
>
> +typedef char *virString;
> +
>  char **virStringSplitCount(const char *string,
>                             const char *delim,
>                             size_t max_tokens,

Not a deal breaker, but I'd probably squash this into the next patch.

Reviewed-by: Erik Skultety <eskultet@xxxxxxxxxx>

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux