Re: [PATCH v2 1/7] qemu: caps: Introduce a capability for egl-headless

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/09/2018 06:24 PM, Erik Skultety wrote:
> Since QEMU 2.10, it's possible to use a new type of display -
> egl-headless which uses drm nodes to provide OpenGL support. This patch
> adds a capability for that. However, since QEMU doesn't provide a QMP
> command to probe it, this is only a libvirt version-based capability.

Well. I'd reword the last sentence. It is technically correct, but we
are actually comparing qemu version not libvirt. How does this sound:

However, since QEMU doesn't provide a QMP command to probe it we have to
base the capability on QEMU version.

> 
> Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx>
> ---
>  src/qemu/qemu_capabilities.c                       | 6 ++++++
>  src/qemu/qemu_capabilities.h                       | 1 +
>  tests/qemucapabilitiesdata/caps_2.10.0.aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_2.10.0.ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_2.10.0.s390x.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_2.10.0.x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_2.11.0.s390x.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.ppc64.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.s390x.xml   | 1 +
>  tests/qemucapabilitiesdata/caps_2.12.0.x86_64.xml  | 1 +
>  tests/qemucapabilitiesdata/caps_3.0.0.ppc64.xml    | 1 +
>  12 files changed, 17 insertions(+)

ACK

Michal

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux