[re-adding libvirt-list] On Mon, 2018-07-09 at 09:23 -0400, Anya Harter wrote: > On 07/09/2018 04:34 AM, Andrea Bolognani wrote: > > On Thu, 2018-07-05 at 13:48 -0400, Anya Harter wrote: > > > +/tests/.pytest_cache > > > > When does the directory (or file?) get created? I just ran 'make > > test' but it's not there for me. > > The tests/.pytest_cache/ directory is created when make check is run and > the test suite fails. > > Additionally, a .pytest_cache/ directory is created in the home > directory if ./run tests/<testfile> fails. s/home directory/top-level directory of the project/ ;) > If you want I can give you a patch that breaks the test suite and > creates the directories in the two ways above. No need: I verified the above on my own, and in that light... > > Either way, this looks like it should be a more generic exclude > > pattern like the one we already have for __pycache__ directories > > instead of being limited to tests/. ... this suggestion was spot-on, as adding the pattern you suggested would take care of the failed 'make check' case but not of the failed './run tests/...' case. Looking forward to v2 :) -- Andrea Bolognani / Red Hat / Virtualization -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
