On Wed, Jul 04, 2018 at 13:51:56 +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1598087 > > We are mentioning the positive outcome of the function and not > the case when live detaching a device is denied and event is > issued. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/libvirt-domain.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c > index c71f2e6877..ab7266dc19 100644 > --- a/src/libvirt-domain.c > +++ b/src/libvirt-domain.c > @@ -8365,7 +8365,9 @@ virDomainUpdateDeviceFlags(virDomainPtr domain, > * asynchronous - it returns immediately after sending the detach > * request to the hypervisor. It's caller's responsibility to > * wait for VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED event to signal > - * actual device removal. > + * actual device removal or for > + * VIR_DOMAIN_EVENT_ID_DEVICE_REMOVAL_FAILED to signal rejected > + * device removal. > * > * Returns 0 in case of success, -1 in case of failure. > */ Reviewed-by: Jiri Denemark <jdenemar@xxxxxxxxxx> -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
