Re: [dbus PATCH] connect: fix g_free order in virtDBusConnectFree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 03, 2018 at 02:18:02PM +0200, Pavel Hrdina wrote:
On Mon, Jul 02, 2018 at 11:42:08AM -0400, Anya Harter wrote:
so that g_free(connect->nodeDevPath) line appears in alphabetical order
with the rest of the lines

Signed-off-by: Anya Harter <aharter@xxxxxxxxxx>
---
 src/connect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

In general we don't send/merge patches that just move code without any
functional reason because it pollutes git history but in this case I
would say it's ok.


What about the gchar *nodeDevPath; declaration in connect.h?
It is also in a different order.

/me runs

Jano

Reviewed-by: Pavel Hrdina <phrdina@xxxxxxxxxx> and pushed.



--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

Attachment: signature.asc
Description: Digital signature

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux