On Wed, Sep 23, 2009 at 03:25:28PM +0100, Mark McLoughlin wrote:
> On Tue, 2009-09-15 at 11:38 +0100, Daniel P. Berrange wrote:
> > With the 0.7.1 relesae out of the way I'd like to suggest that we take
> > this time to move around some files in GIT to correct some long standing
> > wierd/bad naming decisions :-)
> >
> >
> > The qemud/ directory is better named 'daemon', and some of the things
> > in there should really have been in the src/ directory. So...
> >
> > * qemud/ -> daemon/
> > * qemud/qemud.{h,c} daemon/main.{h,c}
> > * qemud/default-network.xml -> src/network/default.xml
> > * qemud/libvirtd_qemu.aug src/qemu/qemu.aug
> > * qemud/test_libvirtd_qemu.aug src/qemu/test_qemu.aug
> > * qemud/remote_protocol.x -> src/remote/remote_protocol.x
> >
> >
> > In the src/ directory we should move the rest of the drivers into their
> > own sub-directories. Basically want one sub directory for each of the
> > 'mod_LTLIBRARIES' declared in the src/Makefile.am. This will ensure we
> > keep separate build dependancies, not accidentally including files that
> > we shouldn't.
> >
> > * src/qemu_*.{c,h} -> src/qemu/
> > * src/xen_unified.{c,h} -> src/xen/xen_driver.{c,h}
> > * src/xend_*, src/xm_* src/xen_* -> src/xen/
> > * src/test.{c,h} -> src/test/test_driver.{c,h}
> > * src/storage*.{c,h} -> src/storage/
> > * src/security*.{c,h} -> src/security/
> > * src/remote_internal.{c,h} -> src/remote/remote_driver.{c,h}
> > * src/interface_driver.c -> src/interface/netcf_driver.c
> > * src/network_driver.c -> src/network/network_driver.c
>
> Why did you go with src/network/bridge_driver.[ch] for this ?
It is an implementation of the network driver using a bridge, but will
not be the only impl forever. I'm planning ahead for the time when we
add a 2nd implementation of the network driver, that is based on using
NetworkManager to manage this functionality. This is what will finally
enable qemu:///session to become a viable option for desktop virt since
we won't need to have root privileges for messing around with bridges.
> It doesn't seem right to me - we refer to it as the network driver, all
> the code is networkFooBar(), it's in the network/ directory, ...
Ideally we'd rename the methods, but I didn't think that would be
worth the churn
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
--
Libvir-list mailing list
Libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list