On 06/27/2018 09:34 AM, Erik Skultety wrote: > QEMU uses a shorthand '-sdl' which maps to '-display sdl'. However, if > there are any options to be passed to SDL, the full command version must > be used. Everything seemingly worked for us until commit 5038b300437 > introduced OpenGL support for SDL and added ',gl=on/off' option which as > mentioned above could have never worked with the shorthand version of > the command. Indeed starting a domain with an SDL display and OpenGL > enabled, QEMU produces a rather cryptic error: > > -sdl: Could not open 'gl=on': No such file or directory > > This patch provides fixes to both the SDL cmdline generation and the > test suite. > > Signed-off-by: Erik Skultety <eskultet@xxxxxxxxxx> > --- > src/qemu/qemu_command.c | 19 +++++++++++-------- > tests/qemuxml2argvdata/graphics-sdl-fullscreen.args | 2 +- > tests/qemuxml2argvdata/graphics-sdl.args | 2 +- > tests/qemuxml2argvdata/video-virtio-gpu-sdl-gl.args | 2 +- > 4 files changed, 14 insertions(+), 11 deletions(-) > Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx> John Weird on this one... I thought I looked through qemu sources to see if this would work right. Maybe I just didn't look hard enough - cannot recall. Oh well glad you fixed it <sigh>. -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
