On Thu, Jun 28, 2018 at 02:45:38PM +0200, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1541921 > > In TCG mode, there are no vCPU threads and thus there's nothing > to be placed into resctrl CGroup. Forbid such configuration. This reminds me (again) that we need to add MTTCG support to libvirt which allows one thread per vCPU with TCG. > > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > src/qemu/qemu_domain.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index fee44812c1..a39d9a46a0 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -3980,6 +3980,13 @@ qemuDomainDefValidate(const virDomainDef *def, > } > } > > + if (def->ncachetunes && > + def->virtType != VIR_DOMAIN_VIRT_KVM) { > + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", > + _("cachetune is only supported for KVM domains")); > + goto cleanup; > + } > + > if (qemuDomainDefValidateFeatures(def, qemuCaps) < 0) > goto cleanup; Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
