On Thu, Jun 28, 2018 at 09:53:48AM +0200, Pavel Hrdina wrote: > The same check is done by virNWFilterBindingObjListAdd(). The main > issue with the current code is that if the object already exists we > would leak 'def' because 'obj' would be set and the cleanup code frees > 'def' only if 'obj' is NULL. > > Signed-off-by: Pavel Hrdina <phrdina@xxxxxxxxxx> > --- > src/nwfilter/nwfilter_driver.c | 7 ------- > 1 file changed, 7 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@xxxxxxxxxx> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| -- libvir-list mailing list libvir-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libvir-list
