Re: [PATCH] Fix syntax error on Python 3.7

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27.6.2018 13:54, Miro Hrončok wrote:
On 27.6.2018 13:47, Pavel Hrdina wrote:
On Wed, Jun 27, 2018 at 01:03:03PM +0200, Miro Hrončok wrote:
 From 0d3b7cc9ba787a139ecbe6dac490b1f5bb021b7f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= <miro@xxxxxxxxxx>
Date: Wed, 27 Jun 2018 13:00:28 +0200
Subject: [PATCH] Fix syntax error on Python 3.7

async is a keyword now.

`asyncio import ensure_future` works on Python 3.4 to 3.7

`from asyncio import async as ensure_future` is not needed.
---
  libvirtaio.py | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

Thanks for the patch, but as noted in this review [1] using only
'ensure_future' is not good enough.

Pavel

[1] <https://www.redhat.com/archives/libvir-list/2018-June/msg01700.html>

In that case you need to get async dynamically...


Sorry, I wasn't on the list before and I missed the fact that this is already being handled. Ignore me.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux