Re: [PATCH v4 1/6] virsh: add manpage docs for nwfilter-binding commands.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 06/26/2018 06:23 AM, Daniel P. Berrangé wrote:
> Signed-off-by: Daniel P. Berrangé <berrange@xxxxxxxxxx>
> ---
>  tools/virsh.pod | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 

Just need to add periods to the end of a couple of sentences below

Reviewed-by: John Ferlan <jferlan@xxxxxxxxxx>

John

> diff --git a/tools/virsh.pod b/tools/virsh.pod
> index c9ef4f137c..47985ebf78 100644
> --- a/tools/virsh.pod
> +++ b/tools/virsh.pod
> @@ -4807,6 +4807,41 @@ variables, and defaults to C<vi>.
>  
>  =back
>  
> +=head1 NWFILTER BINDING COMMANDS
> +
> +The following commands manipulate network filter bindings. Network filter
> +bindings track the association between a network port and a network
> +filter. Generally the bindings are managed automatically by the hypervisor
> +drivers when adding/removing NICs on a guest.
> +
> +If an admin is creating/deleting TAP devices for non-guest usage,
> +however, the network filter binding commands provide a way to make use
> +of the network filters directly.
> +
> +=over 4
> +
> +=item B<nwfilter-binding-create> I<xmlfile>
> +
> +Associate a network port with a network filter. The network filter backend
> +will immediately attempt to instantiate the filter rules on the port.
> +
> +=item B<nwfilter-binding-undefine> I<port-name>
> +
> +Disassociate a network port from a network filter. The network filter
> +backend will immediately tear down the filter rules that exist on the
> +port.
> +
> +=item B<nwfilter-binding-list>
> +
> +List all of the network ports which have filters associated with them

s/them/them.

> +
> +=item B<nwfilter-binding-dumpxml> I<port-name>
> +
> +Output the network filter binding XML for the network device called
> +C<port-name>

s/>/>.

> +
> +=back
> +
>  =head1 HYPERVISOR-SPECIFIC COMMANDS
>  
>  NOTE: Use of the following commands is B<strongly> discouraged.  They
> 

--
libvir-list mailing list
libvir-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libvir-list




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux